Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][EASY] Support create table command for Delta Lake #5529

Closed
3 of 4 tasks
zml1206 opened this issue Oct 26, 2023 · 1 comment
Closed
3 of 4 tasks

[TASK][EASY] Support create table command for Delta Lake #5529

zml1206 opened this issue Oct 26, 2023 · 1 comment
Assignees
@zml1206
Labels
kind:subtask a subtask of umbrella ticket

Comments

@zml1206
Copy link
Contributor

zml1206 commented Oct 26, 2023 •
edited

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the subtask

Support create table command for Delta Lake in Authz plugin.

Parent issue

#5477

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@zml1206 zml1206 added the kind:subtask a subtask of umbrella ticket label Oct 26, 2023
@github-actions
Copy link

Hello @zml1206,
Thanks for finding the time to report the issue!
We really appreciate the community's efforts to improve Apache Kyuubi.

@zml1206 zml1206 mentioned this issue Oct 26, 2023
Closed
3 tasks
This was referenced Oct 30, 2023
Closed
Closed
cfmcgrady pushed a commit that referenced this issue Nov 1, 2023
@zml1206 @cfmcgrady
[KYUUBI #5529][AUTHZ][FOLLOWUP] Remove useless org.apache.spark.sql.d…
9cda08b 
…elta.commands.CreateDeltaTableCommand

### _Why are the changes needed?_
To close #5529 .
Remove useless `org.apache.spark.sql.delta.commands.CreateDeltaTableCommand`.

Because the logical plans for Delta Lake create table and replace table are `org.apache.spark.sql.catalyst.plans.logical.CreateTable`, `org.apache.spark.sql.catalyst.plans.logical.CreateV2Table` and `org.apache.spark.sql.catalyst.plans.logical.ReplaceTable`.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_
No.

Closes #5571 from zml1206/KYUUBI-5529-FOLLOWUP.

Closes #5529

0908571 [zml1206] Remove useless org.apache.spark.sql.delta.commands.CreateDeltaTableCommand

Authored-by: zml1206 <zhuml1206@gmail.com>
Signed-off-by: Fu Chen <cfmcgrady@gmail.com>
yaooqinn pushed a commit that referenced this issue Nov 2, 2023
@zml1206 @yaooqinn
[KYUUBI #5529][AUTHZ][FOLLOWUP] Fix Create table ut for Delta Lake do…
d7be197 
…es not trigger a sql operation

### _Why are the changes needed?_
Fix bug,  Create table ut for Delta Lake does not trigger a sql operation.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

Closes #5597 from zml1206/KYUUBI-5529-FOLLOWUP2.

Closes #5529

9c031dc [zml1206] fix create table ut does not trigger a sql operation

Authored-by: zml1206 <zhuml1206@gmail.com>
Signed-off-by: Kent Yao <yao@apache.org>
YesOrNo828 pushed a commit to YesOrNo828/kyuubi that referenced this issue Nov 6, 2023
@zml1206 @YesOrNo828
[KYUUBI apache#5529][AUTHZ][FOLLOWUP] Remove useless org.apache.spark…
4d1a810 
….sql.delta.commands.CreateDeltaTableCommand

### _Why are the changes needed?_
To close apache#5529 .
Remove useless `org.apache.spark.sql.delta.commands.CreateDeltaTableCommand`.

Because the logical plans for Delta Lake create table and replace table are `org.apache.spark.sql.catalyst.plans.logical.CreateTable`, `org.apache.spark.sql.catalyst.plans.logical.CreateV2Table` and `org.apache.spark.sql.catalyst.plans.logical.ReplaceTable`.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_
No.

Closes apache#5571 from zml1206/KYUUBI-5529-FOLLOWUP.

Closes apache#5529

0908571 [zml1206] Remove useless org.apache.spark.sql.delta.commands.CreateDeltaTableCommand

Authored-by: zml1206 <zhuml1206@gmail.com>
Signed-off-by: Fu Chen <cfmcgrady@gmail.com>
YesOrNo828 pushed a commit to YesOrNo828/kyuubi that referenced this issue Nov 6, 2023
@zml1206 @YesOrNo828
[KYUUBI apache#5529][AUTHZ][FOLLOWUP] Fix Create table ut for Delta L…
248b649 
…ake does not trigger a sql operation

### _Why are the changes needed?_
Fix bug,  Create table ut for Delta Lake does not trigger a sql operation.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

Closes apache#5597 from zml1206/KYUUBI-5529-FOLLOWUP2.

Closes apache#5529

9c031dc [zml1206] fix create table ut does not trigger a sql operation

Authored-by: zml1206 <zhuml1206@gmail.com>
Signed-off-by: Kent Yao <yao@apache.org>
@pan3793 pan3793 changed the title [Subtask] Support create table command for Delta Lake [TASK][EASY] Support create table command for Delta Lake Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zml1206 zml1206

Labels
kind:subtask a subtask of umbrella ticket
Projects
No open projects
2023 Kyuubi Code Contribution Program
Status: Done
Milestone
No milestone
1 participant
@zml1206