Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][EASY] Build dist with metastore sql #5561

Closed
2 of 4 tasks
cxzl25 opened this issue Oct 30, 2023 · 2 comments
Closed
2 of 4 tasks

[TASK][EASY] Build dist with metastore sql #5561

cxzl25 opened this issue Oct 30, 2023 · 2 comments
Assignees
@lsm1
Labels
hacktoberfest
Milestone
v1.8.0

Comments

@cxzl25
Copy link
Contributor

cxzl25 commented Oct 30, 2023

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

copy kyuubi-server/src/main/resources/sql to dist tar.

e.g. Hive meta store
https://github.com/apache/hive/blob/40551ff4669325defa08ff2adc0b497296cf46fa/standalone-metastore/metastore-server/src/assembly/bin.xml#L85-L91

How should we improve?

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@lsm1
Copy link
Contributor

lsm1 commented Oct 30, 2023

I will try it, please assgin to me

@cxzl25 cxzl25 changed the title [Improvement] Build dist with metastore sql [TASK][EASY] Build dist with metastore sql Oct 30, 2023
@pan3793
Copy link
Member

pan3793 commented Oct 31, 2023

thanks, it was reported a few times by users, and this should be included in 1.8.0

@yaooqinn yaooqinn added this to the v1.8.0 milestone Oct 31, 2023
@lsm1 lsm1 mentioned this issue Oct 31, 2023
Closed
3 tasks
@pan3793 pan3793 closed this as completed in c81124b Nov 1, 2023
pan3793 pushed a commit that referenced this issue Nov 1, 2023
@lsm1 @pan3793
[KYUUBI #5561] Binary distribution artifact ships database schema scr…
91642f4 
…ipts

### _Why are the changes needed?_

close #5561
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

NO

Closes #5589 from lsm1/branch-kyuubi-5561.

Closes #5561

831f06a [senmiaoliu] just copy server resource sql
64b90b1 [senmiaoliu] copy metadata sql to dist

Authored-by: senmiaoliu <senmiaoliu@trip.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit c81124b)
Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793 added a commit to pan3793/kyuubi that referenced this issue Nov 1, 2023
@pan3793
[KYUUBI apache#5561][FOLLOWUP] Rename folder to db-scripts
17cdd66
pan3793 added a commit that referenced this issue Nov 1, 2023
@pan3793
[KYUUBI #5561][FOLLOWUP] Rename folder to db-scripts
27d845c 
### _Why are the changes needed?_

Minor, just rename a folder.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

No

Closes #5598 from pan3793/db-scripts.

Closes #5561

17cdd66 [Cheng Pan] [KYUUBI #5561][FOLLOWUP] Rename folder to db-scripts

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
pan3793 added a commit that referenced this issue Nov 1, 2023
@pan3793
[KYUUBI #5561][FOLLOWUP] Rename folder to db-scripts
54f7713 
### _Why are the changes needed?_

Minor, just rename a folder.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

No

Closes #5598 from pan3793/db-scripts.

Closes #5561

17cdd66 [Cheng Pan] [KYUUBI #5561][FOLLOWUP] Rename folder to db-scripts

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit 27d845c)
Signed-off-by: Cheng Pan <chengpan@apache.org>
YesOrNo828 pushed a commit to YesOrNo828/kyuubi that referenced this issue Nov 6, 2023
@lsm1 @YesOrNo828
[KYUUBI apache#5561] Binary distribution artifact ships database sche…
acc6cde 
…ma scripts

### _Why are the changes needed?_

close apache#5561
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

NO

Closes apache#5589 from lsm1/branch-kyuubi-5561.

Closes apache#5561

831f06a [senmiaoliu] just copy server resource sql
64b90b1 [senmiaoliu] copy metadata sql to dist

Authored-by: senmiaoliu <senmiaoliu@trip.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
YesOrNo828 pushed a commit to YesOrNo828/kyuubi that referenced this issue Nov 6, 2023
@pan3793 @YesOrNo828
[KYUUBI apache#5561][FOLLOWUP] Rename folder to db-scripts
394c3eb 
### _Why are the changes needed?_

Minor, just rename a folder.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

No

Closes apache#5598 from pan3793/db-scripts.

Closes apache#5561

17cdd66 [Cheng Pan] [KYUUBI apache#5561][FOLLOWUP] Rename folder to db-scripts

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsm1 lsm1

Labels
hacktoberfest
Projects
No open projects
2023 Kyuubi Code Contribution Program
Status: Done
Milestone
v1.8.0
Development

Successfully merging a pull request may close this issue.

[KYUUBI #5561] Binary distribution artifact ships database schema scripts lsm1/kyuubi
4 participants
@cxzl25 @yaooqinn @lsm1 @pan3793