Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][UI] Fix Menu header font style with Local System issue #5608

Closed
3 of 4 tasks
zwangsheng opened this issue Nov 2, 2023 · 0 comments
Closed
3 of 4 tasks

Comments

@zwangsheng
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

As title.

How should we improve?

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@pan3793 pan3793 closed this as completed in 2cc4d8f Nov 2, 2023
pan3793 pushed a commit that referenced this issue Nov 2, 2023
… color

### _Why are the changes needed?_

As title, fixed the font style to avoid local system setting

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

MacOs + Chrome + Dark Mode
<img width="1300" alt="截屏2023-11-02 11 43 14" src="https://github.com/apache/kyuubi/assets/52876270/f1fd951a-9d6e-4eb3-a258-506cb58459b0">

MacOs + Chrome + Light Mode
<img width="1298" alt="截屏2023-11-02 11 42 00" src="https://github.com/apache/kyuubi/assets/52876270/2e726961-5539-4e4d-bbda-115820b1165a">

### _Was this patch authored or co-authored using generative AI tooling?_

No

Closes #5609 from zwangsheng/KYUUBI#5608.

Closes #5608

a336708 [zwangsheng] [KYUUBI #5608][Improvement][UI] Fix Menu header font style with Local System issue

Authored-by: zwangsheng <binjieyang@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit 2cc4d8f)
Signed-off-by: Cheng Pan <chengpan@apache.org>
YesOrNo828 pushed a commit to YesOrNo828/kyuubi that referenced this issue Nov 6, 2023
… light color

### _Why are the changes needed?_

As title, fixed the font style to avoid local system setting

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [x] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

MacOs + Chrome + Dark Mode
<img width="1300" alt="截屏2023-11-02 11 43 14" src="https://github.com/apache/kyuubi/assets/52876270/f1fd951a-9d6e-4eb3-a258-506cb58459b0">

MacOs + Chrome + Light Mode
<img width="1298" alt="截屏2023-11-02 11 42 00" src="https://github.com/apache/kyuubi/assets/52876270/2e726961-5539-4e4d-bbda-115820b1165a">

### _Was this patch authored or co-authored using generative AI tooling?_

No

Closes apache#5609 from zwangsheng/KYUUBI#5608.

Closes apache#5608

a336708 [zwangsheng] [KYUUBI apache#5608][Improvement][UI] Fix Menu header font style with Local System issue

Authored-by: zwangsheng <binjieyang@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant