Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] [MINOR] Add .java-version into git ignore #6071

Closed
3 of 4 tasks
yanghua opened this issue Feb 22, 2024 · 2 comments
Closed
3 of 4 tasks

[Improvement] [MINOR] Add .java-version into git ignore #6071

yanghua opened this issue Feb 22, 2024 · 2 comments

Comments

@yanghua
Copy link
Contributor

yanghua commented Feb 22, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

git ignore file

How should we improve?

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@yanghua
Copy link
Contributor Author

yanghua commented Feb 22, 2024

.jave-version is generated by jenv. jenv is a popular Java environment management tool.

@pan3793
Copy link
Member

pan3793 commented Feb 22, 2024

SGTM

yanghua added a commit to yanghua/incubator-kyuubi that referenced this issue Feb 22, 2024
@yanghua
[KYUUBI apache#6071] Add .java-version into git ignore
cae4a47
@pan3793 pan3793 mentioned this issue Feb 22, 2024
Closed
4 tasks
pan3793 pushed a commit that referenced this issue Feb 22, 2024
@yanghua @pan3793
[KYUUBI #6071] Add .java-version into git ignore
d9dfe49 
# 🔍 Description
## Issue References 🔗

This pull request fixes #6071

## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6072 from yanghua/kyuubi-6071.

Closes #6071

cae4a47 [yanghua] [KYUUBI #6071] Add .java-version into git ignore

Authored-by: yanghua <yanghua1127@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit e4f9c5d)
Signed-off-by: Cheng Pan <chengpan@apache.org>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this issue Mar 21, 2024
@yanghua @zhaohehuhu
[KYUUBI apache#6071] Add .java-version into git ignore
756dea4 
# 🔍 Description
## Issue References 🔗

This pull request fixes apache#6071

## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6072 from yanghua/kyuubi-6071.

Closes apache#6071

cae4a47 [yanghua] [KYUUBI apache#6071] Add .java-version into git ignore

Authored-by: yanghua <yanghua1127@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
yanghua added a commit to yanghua/incubator-kyuubi that referenced this issue Apr 21, 2024
@yanghua
[KYUUBI apache#6071] Add .java-version into git ignore
c2691c4 
# 🔍 Description
## Issue References 🔗

This pull request fixes apache#6071

## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes apache#6072 from yanghua/kyuubi-6071.

Closes apache#6071

cae4a47 [yanghua] [KYUUBI apache#6071] Add .java-version into git ignore

Authored-by: yanghua <yanghua1127@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #6071] Add .java-version into git ignore yanghua/incubator-kyuubi
2 participants
@yanghua @pan3793