Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VhdImage and ex_list_public_ips in ARM driver #1035

Merged
merged 2 commits into from Apr 21, 2017
Merged

Fix VhdImage and ex_list_public_ips in ARM driver #1035

merged 2 commits into from Apr 21, 2017

Conversation

tonybaloney
Copy link
Contributor

I noticed that AzureVhdImage __repr__ would never work because it doesn't have a location field.

Also, this string would never render.
https://github.com/apache/libcloud/blame/trunk/libcloud/compute/drivers/azure_arm.py#L1040-L1055

What is the correct URL? @techhat @tetron do you know?

@tetron
Copy link
Contributor

tetron commented Apr 20, 2017

If it's consistent with the other API endpoints then it probably should be:

        action = "/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Network" \
                 "/publicIPAddresses" % (self.subscription_id, resource_group)

@tetron
Copy link
Contributor

tetron commented Apr 20, 2017

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 69a80e5 on tonybaloney:azure_arm_fixes into ** on apache:trunk**.

@tonybaloney
Copy link
Contributor Author

merging

@asfgit asfgit merged commit 69a80e5 into apache:trunk Apr 21, 2017
asfgit pushed a commit that referenced this pull request Apr 21, 2017
asfgit pushed a commit that referenced this pull request Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants