Fix docker's list_containers function #1043
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add an extra check otherwise list_containers breaks with AttributeError
Fix function list_containers for docker
Description
I tested locally docker's list_containers(), which was expected to return a list of containers.
But i ended up with this
I investigated more and i fixed this previous commit
2f9c3a3
I extended the previous check with
'fromImage' in self.request.url
, so to restrict that check whichrefers to install_image and only. Because
self.headers.get('transfer-encoding') == 'chunked'
is valid in other cases too. This way everything seems to work fine!done
Checklist (tick everything that applies)