Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrape prices for Australia region in GCE compute driver #1085

Closed
wants to merge 1 commit into from
Closed

Scrape prices for Australia region in GCE compute driver #1085

wants to merge 1 commit into from

Conversation

fjros
Copy link
Contributor

@fjros fjros commented Jul 12, 2017

Scrape prices for Australia region in GCE compute driver

Description

Update contrib/update_google_prices.py to scrape the price of GCE sizes in the Australia (Sydney) region.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.861% when pulling 8bfd0a7 on fjros:scrape-gce-australia-prices into 6058213 on apache:trunk.

Copy link
Contributor

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Tested locally, works as expected. Maybe we should have a commit to update pricing.json itself too?

@fjros
Copy link
Contributor Author

fjros commented Jul 17, 2017

Thanks @pquentin! I wondered the same... Ideally that should be part of either the build pipeline or the release process, but have no idea if that's the case in practice. If not, just let me know and I'll be happy to update pricing.json :-)

@tonybaloney
Copy link
Contributor

👍 thanks @fjros

@asfgit asfgit closed this in b88cf76 Jul 24, 2017
asfgit pushed a commit that referenced this pull request Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants