[LIBCLOUD-944] Add support for private IP addresses in GCE instance creation

[gmacf]

Add support for private IP addresses in GCE instance creation

Description

GCE driver doesn't currently allow private IPs to be specified when creating instances. Updated gce.py driver to allow the optional parameter internal_ip which can be used when creating GCE instances.

Status

• done, ready for review

Checklist (tick everything that applies)

• Code linting (required, can be done after the PR checks)
• Documentation
• Tests
• ICLA (required for bigger changes)

[coveralls]

Coverage decreased (-0.004%) to 88.966% when pulling 27d79ea on vongazman:LIBCLOUD-944_private_ip into f1bff48 on apache:trunk.

[pquentin]

Thank you @vongazman for your contribution. Great first-time GitHub contribution! The changes make perfect sense! 👍

However, this pull requests lacks tests. I realize that the existing external_ip parameter is not tested, but I believe you should add tests at least for internal_ip. You can look at the DimensionData tests to see how you can update the fixtures and test code to do that.

[codecov-io]

Codecov Report

Merging #1107 into trunk will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##            trunk    #1107      +/-   ##
==========================================
+ Coverage   85.48%   85.48%   +<.01%     
==========================================
  Files         348      348              
  Lines       66443    66456      +13     
  Branches     5914     5916       +2     
==========================================
+ Hits        56796    56809      +13     
  Misses       7239     7239              
  Partials     2408     2408

Impacted Files	Coverage Δ
libcloud/compute/drivers/gce.py	76.05% <100%> (+0.01%)	⬆️
libcloud/test/compute/test_gce.py	97.57% <100%> (+0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e1972e...a8276e2. Read the comment docs.

[pquentin]

Great, thank you for adding tests! There's one issue left with DELETE. Thanks.

[pquentin]

It looks like you had started to test the DELETE path but ended up not to? Either add the file or remove the reference to it.

[gmacf]

Thanks, I removed the reference to it.

[pquentin]

Thanks @vongazman! ✨ I've included this in trunk.

(Reworked the commits to remove the intermediate ones that would have made bisecting difficult, and signed them off as part of the standard procedure.)