Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ex_enable_ipv6 in DigitalOcean_v2 driver #1130

Closed
wants to merge 1 commit into from

Conversation

vdloo
Copy link
Member

@vdloo vdloo commented Oct 15, 2017

add ex_enable_ipv6 in DigitalOcean_v2 driver

So ipv6 can be enabled on a Droplet using the API

To enable IPv6 networking on an existing Droplet (within a region that has IPv6 available), send
a POST request to /v2/droplets/$DROPLET_ID/actions. Set the "type" attribute to enable_ipv6.

https://developers.digitalocean.com/documentation/v2/#enable-ipv6

@codecov-io
Copy link

codecov-io commented Oct 15, 2017

Codecov Report

Merging #1130 into trunk will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #1130      +/-   ##
==========================================
+ Coverage   85.47%   85.47%   +<.01%     
==========================================
  Files         348      348              
  Lines       66409    66421      +12     
  Branches     5909     5909              
==========================================
+ Hits        56760    56772      +12     
  Misses       7242     7242              
  Partials     2407     2407
Impacted Files Coverage Δ
libcloud/compute/drivers/digitalocean.py 81.08% <100%> (+0.41%) ⬆️
libcloud/test/compute/test_digitalocean_v2.py 99.27% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef35d34...96e5097. Read the comment docs.

Copy link
Contributor

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the changes look good! I only have one question about a v1 fixture.

@@ -0,0 +1,13 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since your change only applies to the v2 driver, this file is not needed right? Can you please remove it? Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, done!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pquentin also see #1131, those two fixtures also are not needed I think because those methods only apply to the v2 driver as well

> To enable IPv6 networking on an existing Droplet
> (within a region that has IPv6 available), send
> a POST request to /v2/droplets/$DROPLET_ID/actions.
> Set the "type" attribute to enable_ipv6.

https://developers.digitalocean.com/documentation/v2/
@pquentin
Copy link
Contributor

Thank you, this has been merged in trunk! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants