Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google compute] Add license strings for new GCE images #1136

Closed
wants to merge 2 commits into from

Conversation

erjohnso
Copy link
Member

@erjohnso erjohnso commented Oct 18, 2017

[google compute] Allow adding license strings to GCE images

Description

Allow for insertion of license strings when creating a new GCE image [https://cloud.google.com/compute/docs/reference/latest/images]

Status

First pass at implementation, needs tests.

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

/cc @katrielt

@pquentin
Copy link
Contributor

Looks good! Can you please update test_ex_create_image too? Thanks!

@erjohnso
Copy link
Member Author

Thank you @pquentin - tests added and passing, I'll go ahead and merge.

@codecov-io
Copy link

Codecov Report

Merging #1136 into trunk will increase coverage by <.01%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #1136      +/-   ##
==========================================
+ Coverage   85.47%   85.47%   +<.01%     
==========================================
  Files         348      348              
  Lines       66421    66443      +22     
  Branches     5909     5914       +5     
==========================================
+ Hits        56774    56794      +20     
- Misses       7240     7241       +1     
- Partials     2407     2408       +1
Impacted Files Coverage Δ
libcloud/test/compute/test_gce.py 97.56% <100%> (ø) ⬆️
libcloud/compute/drivers/gce.py 76.04% <25%> (-0.08%) ⬇️
libcloud/test/compute/test_ec2.py 97.77% <0%> (-0.14%) ⬇️
libcloud/compute/drivers/ec2.py 74.25% <0%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea3646...f046045. Read the comment docs.

@asfgit asfgit closed this in 5e1972e Oct 19, 2017
@pquentin
Copy link
Contributor

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants