Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIBCLOUD-965] /v3/OS-FEDERATION/projects deprecated in OpenStack OIDC auth #1145

Closed
wants to merge 7 commits into from

Conversation

micafer
Copy link
Contributor

@micafer micafer commented Nov 29, 2017

[LIBCLOUD-965] /v3/OS-FEDERATION/projects deprecated in OpenStack OIDC auth

Description

As stated here:
https://developer.openstack.org/api-ref/identity/v3-ext/#list-projects-a-federated-user-can-access

The path: /v3/OS-FEDERATION/projects has been deprecated in v1.1. Use core GET /auth/projects. This call has the same response format.

Also added response.body as body of the MalformedResponseError to improve error messages in case of non expected response code.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@micafer micafer closed this Nov 29, 2017
@micafer micafer reopened this Nov 29, 2017
@micafer micafer closed this Nov 30, 2017
@micafer micafer reopened this Nov 30, 2017
@micafer micafer changed the title Improve error messages in VOMS and OIDC OpenStackIdentity connectors [LIBCLOUD-965] /v3/OS-FEDERATION/projects deprecated in OpenStack OIDC auth Nov 30, 2017
@micafer micafer closed this Nov 30, 2017
@micafer micafer reopened this Nov 30, 2017
@codecov-io
Copy link

codecov-io commented Nov 30, 2017

Codecov Report

Merging #1145 into trunk will increase coverage by 0.59%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #1145      +/-   ##
==========================================
+ Coverage   85.52%   86.11%   +0.59%     
==========================================
  Files         348      348              
  Lines       66579    66890     +311     
  Branches     5924     5938      +14     
==========================================
+ Hits        56941    57604     +663     
+ Misses       7233     6858     -375     
- Partials     2405     2428      +23
Impacted Files Coverage Δ
libcloud/test/common/test_openstack_identity.py 97.94% <100%> (-0.62%) ⬇️
libcloud/common/openstack_identity.py 75.87% <100%> (+0.09%) ⬆️
libcloud/storage/base.py 82.8% <0%> (-5.1%) ⬇️
libcloud/common/cloudstack.py 86.59% <0%> (-1.83%) ⬇️
libcloud/test/compute/test_deployment.py 94.7% <0%> (-0.2%) ⬇️
libcloud/compute/drivers/ec2.py 74.25% <0%> (ø) ⬆️
libcloud/test/storage/test_aurora.py 100% <0%> (ø) ⬆️
libcloud/storage/drivers/digitalocean_spaces.py 100% <0%> (ø) ⬆️
libcloud/test/compute/test_cloudstack.py 99.51% <0%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f7637e...ca38440. Read the comment docs.

@micafer micafer closed this Dec 5, 2017
@micafer micafer reopened this Dec 5, 2017
@pquentin
Copy link
Contributor

@micafer Thank you for your contribution!

Unfortunately the old path is no longer covered by tests. Are the OpenStack versions that need the old path still supported? If yes, we need somehow two tests to test the two paths. If it can be removed, then let's do that!

I don't have other issues with your code. Thanks!

@micafer
Copy link
Contributor Author

micafer commented Jan 30, 2018

Hi @pquentin ,
I have added a new test to cover the old path.

@asfgit asfgit closed this in b06b609 Jan 30, 2018
@pquentin
Copy link
Contributor

Thanks! Merged in trunk. ✨ Can you please close the LIBCLOUD issue? I can't do that myself.

@micafer
Copy link
Contributor Author

micafer commented Jan 31, 2018

LIBCLOUD issue closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants