New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image member methods to openstackv2 #1172
Conversation
b4e776c
to
dde3ea2
Compare
Can you please rebase your changes on top of the latest trunk? It would allow to see coverage info, since the latest trunk fixes an issue with sphinx. Thanks! |
dde3ea2
to
3ccc1d8
Compare
yes no problem. also please see #1151, this PR depends on and includes that one |
Codecov Report
@@ Coverage Diff @@
## trunk #1172 +/- ##
==========================================
+ Coverage 86.13% 86.17% +0.03%
==========================================
Files 348 348
Lines 66981 67137 +156
Branches 5952 5956 +4
==========================================
+ Hits 57694 57853 +159
+ Misses 6857 6853 -4
- Partials 2430 2431 +1
Continue to review full report at Codecov.
|
|
||
def ex_list_image_member(self, image_id, member_id): | ||
""" | ||
List a member of an image by id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a good reason to call this operation list and not get?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, has been changed to ex_get_image_member now to conform to the convention
da8b397
to
35ee494
Compare
rebased on origin/trunk |
Thanks! Merged in trunk. ✨ |
Add list image member methods to openstack v2 driver
includes and depends on #1151
this allows listing image members, see https://developer.openstack.org/api-ref/image/v2/index.html#sharing. in openstack you can share images between tenants. when an image is set to 'shared' other tenants can be added as 'member'. all members of an image can be listed to see which tenants have access and if they have accepted or rejected the membership yet or if it is still pending. this PR adds the new NodeImageMember class which contains image id, member id, state and more.
list image members
list image member:
Status