Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS eu-west-3 #1175

Closed
wants to merge 1 commit into from
Closed

Added AWS eu-west-3 #1175

wants to merge 1 commit into from

Conversation

ZuluPro
Copy link
Contributor

@ZuluPro ZuluPro commented Feb 24, 2018

Added eu-west-3

Description

Main reference: https://aws.amazon.com/fr/blogs/aws/now-open-aws-eu-paris-region/
The tests are failing on docs, which I didn't touch...

Status

Done

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@ZuluPro ZuluPro changed the title Added eu-west-3 Added AWS eu-west-3 Feb 24, 2018
@pquentin
Copy link
Contributor

Yes, the docs failure were due to Sphinx 1.7.1. I pinned it to 1.6.7 for now. The change looks good.

Do you think we could update the docs to mention all those regions? See http://libcloud.readthedocs.io/en/latest/compute/drivers/ec2.html. It can be in a separate pull request if you prefer. There is a list in http://libcloud.readthedocs.io/en/latest/compute/supported_providers.html but it should probably be removed there because it's unusable?

@asfgit asfgit closed this in 5dd4b8e Feb 25, 2018
@pquentin
Copy link
Contributor

I decided to merge this in trunk to ensure it's in libcloud 2.3.0. The documentation changes can wait, but if somebody wants to work on them it would be great.

@ZuluPro
Copy link
Contributor Author

ZuluPro commented Feb 26, 2018

NP, I'll update docs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants