Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify chained comparisons #1183

Closed
wants to merge 1 commit into from
Closed

Simplify chained comparisons #1183

wants to merge 1 commit into from

Conversation

remyleone
Copy link
Contributor

Simplify chained comparisons

Description

Comparisons could be simplified and easier to read

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@codecov-io
Copy link

Codecov Report

Merging #1183 into trunk will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #1183      +/-   ##
==========================================
- Coverage   86.19%   86.19%   -0.01%     
==========================================
  Files         348      348              
  Lines       67263    67263              
  Branches     5958     5958              
==========================================
- Hits        57979    57977       -2     
- Misses       6851     6852       +1     
- Partials     2433     2434       +1
Impacted Files Coverage Δ
libcloud/utils/py3.py 46.25% <0%> (ø) ⬆️
libcloud/storage/drivers/cloudfiles.py 80.09% <100%> (ø) ⬆️
libcloud/compute/drivers/opennebula.py 94.04% <100%> (ø) ⬆️
libcloud/common/brightbox.py 53.65% <100%> (ø) ⬆️
libcloud/common/openstack.py 82.35% <100%> (ø) ⬆️
libcloud/compute/drivers/cloudsigma.py 84.42% <100%> (ø) ⬆️
libcloud/storage/drivers/oss.py 70% <100%> (ø) ⬆️
libcloud/common/aliyun.py 72.16% <100%> (ø) ⬆️
libcloud/storage/drivers/s3.py 88.86% <100%> (ø) ⬆️
libcloud/dns/drivers/powerdns.py 77.85% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0310ba9...47eec29. Read the comment docs.

@asfgit asfgit closed this in 6a8933f Mar 16, 2018
@pquentin
Copy link
Contributor

Thanks! Merged in trunk. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants