Unset the http_proxy environment variable before running tests. #1236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unset the http_proxy environment variable before running tests.
Description
Two connection tests (test_constructor and test_connection_to_unusual_port)
assume that there is no external real proxy in the test environment. Turns
out LibcloudConnection() will honor a http_proxy shell variable if it's set,
so if the test suite is run in such an environment, these tests will fail:
I also added a test for this behavior (the honoring of
http_proxy
) to the existingtest_constructor
test.Status
Checklist (tick everything that applies)