Add china northwest driver about aws #1241
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #1241 +/- ##
==========================================
+ Coverage 86.26% 86.27% +<.01%
==========================================
Files 351 351
Lines 67962 67971 +9
Branches 5987 5987
==========================================
+ Hits 58630 58643 +13
+ Misses 6888 6885 -3
+ Partials 2444 2443 -1
Continue to review full report at Codecov.
|
|
You could add a test here, but that only exists for a couple of the currently available S3StorageDrivers anyway so I'm not sure if that's a big deal. |
libcloud/storage/providers.py
Outdated
| @@ -37,6 +37,8 @@ | |||
| ('libcloud.storage.drivers.s3', 'S3USGovWestStorageDriver'), | |||
| Provider.S3_CN_NORTH: | |||
| ('libcloud.storage.drivers.s3', 'S3CNNorthStorageDriver'), | |||
| Provider.S3_CN_NORTHQWEST: | |||
There was a problem hiding this comment.
Was this Q intended? Or did you perhaps mean S3_CN_NORTHWEST instead of S3_CN_NORTHQWEST here?
There was a problem hiding this comment.
sorry, it‘s spelling mistakes，i will add the test and check my code repeatedly；
And, in my company, the s3 service is in cn-northwest region, the technicist of aws told us servers in this region will raise continuously. without that change, using libcloud to access s3 object in cn-northwest won't work. so this is a important deal for us! Sorry for my mistake again!
|
@yangkang55 Thanks! Merged in trunk. ✨ |
|
Thanks @vdloo! |
Add china northwest driver about aws
Description
in order to use this in chia ningxia province s3 service ,so
Add china northwest driver about aws
Add china northwest type about aws
Add china northwest providers about aws
Status
done, ready for review
Checklist (tick everything that applies)