Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SUSPENDED NodeState in OpenStack driver #1269

Closed
wants to merge 9 commits into from

Conversation

micafer
Copy link
Contributor

@micafer micafer commented Dec 18, 2018

Set SUSPENDED NodeState in OpenStack driver

Description

Currently the 'SUSPENDED' VM status is mapped to the STOPPED NodeState value.
The correct value must be the SUSPENDED NodeState one.

Status

  • done, ready for review

Checklist (tick everything that applies)

  • Code linting (required, can be done after the PR checks)
  • Documentation
  • Tests
  • ICLA (required for bigger changes)

@codecov-io
Copy link

Codecov Report

Merging #1269 into trunk will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk    #1269   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files         356      356           
  Lines       73220    73220           
  Branches     6645     6645           
=======================================
  Hits        62861    62861           
- Misses       7707     7708    +1     
+ Partials     2652     2651    -1
Impacted Files Coverage Δ
libcloud/compute/drivers/openstack.py 85.24% <ø> (ø) ⬆️
libcloud/test/compute/test_ec2.py 97.74% <0%> (-0.17%) ⬇️
libcloud/test/compute/test_upcloud.py 91.39% <0%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de159ec...b9b0207. Read the comment docs.

@vdloo
Copy link
Member

vdloo commented Dec 18, 2018

Good catch 👍

@asfgit asfgit closed this in 776c364 Dec 18, 2018
@vdloo
Copy link
Member

vdloo commented Dec 18, 2018

Thanks! Merged in trunk. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants