Add aliyun ecs instance join leave security group #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+10086 |
tonybaloney
requested changes
Apr 1, 2017
libcloud/compute/drivers/ecs.py
Outdated
| if group_id is None: | ||
| raise AttributeError('group_id is required') | ||
|
|
||
| if (node.state != NodeState.RUNNING) and \ |
There was a problem hiding this comment.
no parentheses in Python :-) please use a more Pythonic evaluation statement.
libcloud/compute/drivers/ecs.py
Outdated
| :type node: :class:`Node` | ||
|
|
||
| :param group_id: security group id. | ||
| :type ex_filters: ``str`` |
There was a problem hiding this comment.
this should be :type group_id:
libcloud/compute/drivers/ecs.py
Outdated
| if group_id is None: | ||
| raise AttributeError('group_id is required') | ||
|
|
||
| if (node.state != NodeState.RUNNING) and \ |
There was a problem hiding this comment.
again, no parens in Python
libcloud/compute/drivers/ecs.py
Outdated
| :type node: :class:`Node` | ||
|
|
||
| :param group_id: security group id. | ||
| :type ex_filters: ``str`` |
There was a problem hiding this comment.
this docstring title is wrong, it should be :type group_id
There was a problem hiding this comment.
OK, Thank you, I will fix it
fix doc
fix doc
fix for code review
|
thanks, merging. |
|
this is merged. I don't know why this is still here. |
asfgit
pushed a commit
that referenced
this pull request
Apr 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add aliyun ecs instance join leave security group
Description
When I use libcloud in my project, I need use function about "Join/Leave Security Group" for Aliyun ECS instance. But I can not find it in libcloud. That's why I make this pull request.
Two functions are added: join_security_group/leave_security_group
Status
Checklist (tick everything that applies)