Add r4 instance types for AWS #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisstea
reviewed
Mar 6, 2017
contrib/scrape-ec2-prices.py
Outdated
| @@ -101,12 +110,15 @@ | |||
| REGION_NAME_MAP = { | |||
| 'us-east': 'ec2_us_east', | |||
| 'us-east-1': 'ec2_us_east', | |||
| 'us-east-2': 'ec2_us_east', | |||
There was a problem hiding this comment.
I believe the value should match up to the api_name attribute of the region. Therefore, should this be ec2_us_east_ohio instead?
contrib/scrape-ec2-prices.py
Outdated
| 'us-west': 'ec2_us_west', | ||
| 'us-west-1': 'ec2_us_west', | ||
| 'us-west-2': 'ec2_us_west_oregon', | ||
| 'eu-west-1': 'ec2_eu_west', | ||
| 'eu-west-2': 'ec2_eu_west', |
There was a problem hiding this comment.
If I'm not mistaken, this region is yet to be defined in the driver. That being said, it's worth having but the value should probably be different from the one mapped to by eu-west-1. How ec2_eu_west_2 instead?
|
thanks for the contribution @jdeppe-pivotal there is a small merge conflict to resolve first. please rebase and push a merge commit |
|
the build error is on trunk. changes are good to merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: Add r4 instance types for AWS
Description
Added the following AWS types:
Also updated pricing information.
Status
Checklist (tick everything that applies)