Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkis should support IP Address for service discovery service call,Especially when deployed on K8S #946

Closed
lunescode opened this issue Aug 9, 2021 · 0 comments

Comments

@lunescode
Copy link
Contributor

lunescode commented Aug 9, 2021

Feature request :
Linkis default use hostname for service discovery and service call, but when deploy linkis on k8s , a serverce deploy as pod,the pod name is random, so the communication between services(on k8s is some pods) can not work。So,if linkis support IpAddress for
service discovery service call,it will be very nice!

Need Modify:

  1. Linikis now use eureka for service discovery, in eureka we can set “eureka.instance.prefer-ip-address=true” to use IPAddress,this can modify linkis config to get it;
  2. linkis-commons\linkils-common moudle use hostname+":"+port as serviceInstance name , and in linkis-computation-governance module use serviceInstance name for engine manager, so it required to be modify.
  3. linkis-computation-governance\linkis-engineconn-manager module dynamic create linkis-engineconn for different engines,it is default use hostname,so it required to be modify.
  4. $Install$\sbin\sh directory,some shell script should be modify to add SPRING_ARGS.

Solutions
Depending on “eureka.instance.prefer-ip-address" value to decide linkis use IpAdderess or not,modify above moudle,so Linikis can support both hostname and ip address for service discovery and service call.

@lunescode lunescode changed the title Linkis should support IP Adderss for service discovery service call,Especially when deployed on K8S Linkis should support IP Address for service discovery service call,Especially when deployed on K8S Aug 9, 2021
peacewong added a commit that referenced this issue Aug 16, 2021
support both ip address and hostname for service discovery service call  #946
peacewong added a commit that referenced this issue Sep 28, 2021
Fix bug about PR #950, Related issues: #946.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants