Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc) Missing taglib documentation #1230

Closed
ppkarwasz opened this issue Jan 29, 2023 · 6 comments
Closed

(doc) Missing taglib documentation #1230

ppkarwasz opened this issue Jan 29, 2023 · 6 comments
Labels
documentation Pull requests or issues that affect documentation

Comments

@ppkarwasz
Copy link
Contributor

The "Tag library reference" disappeared after version 2.17.1, while the "TLDDoc documentation" disappeared after version 2.17.2:

https://logging.apache.org/log4j/2.x/log4j-taglib/index.html

@ppkarwasz ppkarwasz added the documentation Pull requests or issues that affect documentation label Jan 29, 2023
@ppkarwasz ppkarwasz added this to the 2.20.0 milestone Jan 29, 2023
@vy
Copy link
Member

vy commented Oct 11, 2023

The page is available under [https://logging.apache.org/log4j/2.x/log4j-taglib.html], which is linked from the menu. That should be good enough for this hardly ever used component, right?

@ppkarwasz ppkarwasz modified the milestones: 2.20.0, 2.x Oct 23, 2023
@ppkarwasz
Copy link
Contributor Author

@vy,

The taglib-maven-plugin has been relaunched: https://github.com/weblegacy/taglib-maven-plugin
Maybe we could generate that part of the documentation again?

@vy
Copy link
Member

vy commented Nov 27, 2023

@ppkarwasz, mind elaborating on your proposal a bit, please? What exactly do you want to replace in the current setup with taglib-maven-plugins which functionality?

@ppkarwasz
Copy link
Contributor Author

@vy,

Before version 2.17.2 the Log4j Taglib module had a:

We should be able to restore this documentation using the plugin from the weblegacy project.

@vy
Copy link
Member

vy commented Nov 27, 2023

The way I see this proposal is as follows:

We will add a Maven plugin configuration and probably HTML redirects (involving .htaccess edits and such) for a module that

  1. after a long period of user feedback, is announced to be removed
  2. nobody complained about its missing docs
  3. Nexus stats indicate no usage

Hence, I give -1 for chasing this further. I would rather have a pom.xml that is clean from one more relic.

@ppkarwasz
Copy link
Contributor Author

I agree with your arguments.

@ppkarwasz ppkarwasz removed this from the 2.x milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests or issues that affect documentation
Projects
None yet
Development

No branches or pull requests

2 participants