Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Apache RAT configuration #92

Closed
ppkarwasz opened this issue Jan 9, 2024 · 2 comments
Closed

Clean up Apache RAT configuration #92

ppkarwasz opened this issue Jan 9, 2024 · 2 comments
Assignees
@ppkarwasz
Labels
enhancement
Milestone
10.6.0

Comments

@ppkarwasz
Copy link
Contributor

Due to the RAT-355 enhancement, Apache Rat 0.16 is now able to implicitly ignore most files ignored by Git.

This allows us to clean up the configuration from all the files that are also in a typical .gitignore.
@ppkarwasz ppkarwasz self-assigned this Jan 9, 2024
@ppkarwasz
Copy link
Contributor Author

This issue is a no-op for logging-parent, but should be applied to logging-log4j2.

I am keeping this issue open until apache/maven-apache-parent#185 is merged and we bump to a new version of the ASF parent.

@ppkarwasz ppkarwasz added this to the 10.x milestone Jan 10, 2024
@vy
Copy link
Member

vy commented Jan 11, 2024

@ppkarwasz, instead of waiting for the next org.apache:apache release, we can

  1. override the org.apache.rat:apache-rat-plugin version ourselves
  2. create an issue to remove the override once the next org.apache:apache release arrives
  3. ship this in 10.6.0

@ppkarwasz ppkarwasz modified the milestones: 10.x, 10.6.0 Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppkarwasz ppkarwasz

Labels
enhancement
Projects
None yet
Milestone
10.6.0
Development

No branches or pull requests
2 participants
@vy @ppkarwasz