Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make DaciukMihovAutomatonBuilder pkg-private? #12321

Closed
gsmiller opened this issue May 21, 2023 · 6 comments
Closed

Can we make DaciukMihovAutomatonBuilder pkg-private? #12321

gsmiller opened this issue May 21, 2023 · 6 comments

Comments

@gsmiller
Copy link
Contributor

Description

There's some good suggestions/discussion around renaming this class in #12310, but I wonder if we should consider making it pkg-private and exposing the build functionality through Automata instead? We already do this with Automata#makeStringUnion, so maybe we could shrink our API footprint and consolidate everything behind Automata?

@mikemccand
Copy link
Member

Oooh I love that idea!

@gsmiller
Copy link
Contributor Author

Thanks @mikemccand. I'll take this up after #12320, unless someone else jumps on it first. I'd like to keep it separate from the changes in #12320 to avoid putting too much in one PR.

@rmuir
Copy link
Member

rmuir commented May 24, 2023

nice idea!

@uschindler
Copy link
Contributor

Yes, yes, yes!

@gsmiller
Copy link
Contributor Author

Actually, on second thought, this will be easy to resolve with the other PR I'm working on (#12320), so I'll go ahead with a PR. Here we go: #12331

@gsmiller
Copy link
Contributor Author

Merged on main (#12331) and also added some deprecation notices on 9.x (#12332).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants