Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow FilteredDocIdSetIterator.match(doc) to throw IOException #12492

Closed
DaddyWri opened this issue Aug 7, 2023 · 1 comment · Fixed by #12554
Closed

Allow FilteredDocIdSetIterator.match(doc) to throw IOException #12492

DaddyWri opened this issue Aug 7, 2023 · 1 comment · Fixed by #12554
Labels
type:enhancement

Comments

@DaddyWri
Copy link
Contributor

DaddyWri commented Aug 7, 2023

Description

It would be convenient if org.apache.lucene.search.FilteredDocIdSetIterator#match(doc) would throw an IOException. Right now I'd have to catch the IOException coming from a value source, and wrap it in a runtime exception and then possible unpack it elsewhere. All users of #match(doc) however already declare to throw an IOException today.
@jpountz
Copy link
Contributor

jpountz commented Aug 13, 2023

If you open a PR, I'll be happy to merge it.

@gokaai gokaai mentioned this issue Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow FilteredDocIdSetIterator.match(doc) to throw IOException gokaai/lucene
2 participants
@jpountz @DaddyWri