Hide the internal data structure of HeapPointWriter #12762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
approved these changes
Nov 18, 2023
|
I didn't notice any performance change. Added javadocs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeapPointWriter uses a a byte array to hold points on heap. This array is access directly from BKD radix selector to sort points in place. In addition the HeapPointReader uses the array to read the points too.
I wanted to check the performance impact of changing this data structure as this array can be very big which plays bad with garbage collector like G1 as the array will be considered humongous. The current structure of HeapPointWriter makes this very difficult.
This PR refactor HeapPointWriter by adding methods for in place sorting and changes HeapPointReader to reads points using a functional interface. It encapsulates the internal byte array inside HeapPointWriter. The nice side effect is it removes some code duplication too.