Mark DrillSideways#createDrillDownFacetsCollector as @Deprecated #12854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmiller
force-pushed
the
GH/ds-remove-createDrillDownFacetsCollector-bp
branch
from
242d58d
to
93ce2f5
Compare
stefanvodita
reviewed
Dec 7, 2023
| @@ -133,7 +133,12 @@ public DrillSideways( | |||
| /** | |||
| * Subclass can override to customize drill down facets collector. Returning {@code null} is valid | |||
| * if no drill down facet collection is needed. | |||
| * | |||
| * @deprecated This is only used by the deprecated {@link #search(DrillDownQuery, Collector)} | |||
There was a problem hiding this comment.
Maybe I'm competely missing it, but I only see a search with CollectorManager in DrillSideways (code), not one with Collector. Was it already deleted?
There was a problem hiding this comment.
It's been removed on main but deprecated on 9.x. Here's a reference:
There was a problem hiding this comment.
Oh, and just to clarify, this is the back-port proposal for this change on main, which would be merged against 9.x.
gsmiller
force-pushed
the
GH/ds-remove-createDrillDownFacetsCollector-bp
branch
from
93ce2f5
to
ffd6eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension hook is only referenced by the also-deprecated
DrillSideways#search(DrillDownQuery, Collector), so let's mark it deprecated as well and remove it on main.