Rollback the tmp storage of BytesRefHash to -1 after sort

[gf2121]

In #12784 we cache buckets into extra slots in BytesRefHash to speed up BytesRefHash#sort. This causes an AssertError for TermsQuery because it could call sort more than once on a BytesRefHash instance. Not sure if any other users were relying on this but it would be great to keep consistent with before.

[ChrisHegarty]

LGTM.

[ChrisHegarty]

@gf2121 I've added the 9.9.2 milestone to this PR. Do you agree? If so, is it possible to merge and backport to the branch_9x and branch_9_9 branches.

[jpountz]

Thanks @gf2121 !

[mikemccand]

Thanks for finding/fixing this @gf2121!

because it could call sort more than once on a BytesRefHash instance

Hmm -- that sounds buggy (on TermsQuery part)? Shouldn't callers be prevented from calling .sort() more than once (I think it is a destructive operation?). Or at least let's fix TermsQuery to not do this?

[cpoerschke]

... Or at least let's fix TermsQuery to not do this?

Thanks for the input! Wondering if perhaps I was too hasty closing out the naive #13019 change ... WDYT?

[mikemccand]

Wondering if perhaps I was too hasty closing out the naive #13019 change ... WDYT?

+1 -- let's reopen? I would rather move towards making this API prevent such abuse than being lenient about it, if we can. Thanks @cpoerschke.