Make IndexInput#prefetch take an offset.
#13363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `IndexInput#prefetch` take an offset instead of being relative to the current position. This avoids requiring callers to seek only to call `prefetch()`.
|
I like this much better from api perspective: it closer maps to |
rmuir
approved these changes
May 14, 2024
|
++ this absolute addressing is much nicer. We could even add |
uschindler
reviewed
May 18, 2024
There was a problem hiding this comment.
Quick review after coming back from vacation: looks fine and seems to work.
I only don't like the we now have absolute APIs in a stream-like interface. So my choice for this API would have been in RandomAccessInput. But others seem to want to have it like that.
I don't care!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
IndexInput#prefetchtake an offset instead of being relative to the current position. This avoids requiring callers to seek only to callprefetch().