Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a FilterIndexOutput #11868

Closed
mdmarshmallow opened this issue Oct 21, 2022 · 4 comments
Closed

Add a FilterIndexOutput #11868

mdmarshmallow opened this issue Oct 21, 2022 · 4 comments
Labels
type:enhancement

Comments

@mdmarshmallow
Copy link
Contributor

Description

We have several subclasses of IndexOutput that have delegates, most recently one was added in this PR: #11796. Adding a FilterIndexOutput, similar to FilterDirectory, to make sure all these delegators get tested properly would be a good idea. (suggested by @mikemccand here: https://github.com/apache/lucene/pull/11796/files#r1000886175).
@mdmarshmallow mdmarshmallow mentioned this issue Oct 21, 2022
Merged
@jpountz
Copy link
Contributor

jpountz commented Nov 10, 2022

Let's do FilterIndexInput at the same time?

@mdmarshmallow
Copy link
Contributor Author

Sounds good, I just started working on this and will make sure to add FilterIndexInput as well.

@mdmarshmallow
Copy link
Contributor Author

Here's the PR: #11958

@mikemccand
Copy link
Member

I think this issue was closed with the above PR? Thank you @mdmarshmallow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpountz @mikemccand @mdmarshmallow