You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For #11905 bug, as an example, the user may get a generic exception "Seek Past EOF".
Can we improve it to include the bogus position? For example, If you can see that offset is negative, it is faster to debug. I think the new MMapDir already has some improvements here. Better error messages would help not just people debugging real world problems, but also developers making new stuff and debugging tests.
For MemorySegmentIndexInput it already has a reworked Exception code where also those suppress unused warnings are gone due to some trick: we just catch the exception, but pass them to a method that maps it to an user readable Lucene exception and regrow it This reduced code duplication and removed most suppress warnings.
The code in memory segments already contains a message to report negative positions. I can change it to show the actual position.
I would backport the exception factory methods to the byte buffer index input, that's a bit mechanical work but makes the code also better readable.
Description
For #11905 bug, as an example, the user may get a generic exception "Seek Past EOF".
Can we improve it to include the bogus position? For example, If you can see that offset is negative, it is faster to debug. I think the new MMapDir already has some improvements here. Better error messages would help not just people debugging real world problems, but also developers making new stuff and debugging tests.
cc: @uschindler
The text was updated successfully, but these errors were encountered: