Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console coloring is off when artifact download is under way #685

Closed
cstamas opened this issue Sep 8, 2022 · 1 comment
Closed

Console coloring is off when artifact download is under way #685

cstamas opened this issue Sep 8, 2022 · 1 comment
Milestone

Comments

@cstamas
Copy link
Member

cstamas commented Sep 8, 2022

Easy to reproduce: just invoke mvnd (I did it on maven-resolver, but I guess any project will do) and use -Dmaven.repo.local=foo to force build to download....

When download is happening (1st build), the output is WHITE (not green). -- more precisely, color is quickly going white-ok, kinda vibrating.

When download is NOT happening (ie. 2nd build using that param above): colorization is OK

@gnodet
Copy link
Contributor

gnodet commented Sep 9, 2022

The 3 blocks of the following code are not consistent wrt to the project id colouring:

if (transfer != null) {
asb
.append(':')
.append(String.format(artifactIdFormat, prj.id))
.append(transfer);
} else if (execution == null) {
asb
.append(':')
.append(prj.id);
} else {
asb
.append(':')
.style(CYAN_FOREGROUND)
.append(String.format(artifactIdFormat, prj.id))
.style(GREEN_FOREGROUND)
.append(execution.getPluginArtifactId())
.append(':')
.append(execution.getMojo())
.append(' ')
.style(AttributedStyle.DEFAULT)
.append('(')
.append(execution.getExecutionId())
.append(')');
}

@gnodet gnodet added this to the 0.8.1 milestone Sep 20, 2022
@gnodet gnodet closed this as completed Sep 20, 2022
@gnodet gnodet modified the milestones: 0.8.1, 0.8.2 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants