Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

UpSampling Operator Documentation is incomplete #13078

Closed
anirudhacharya opened this issue Nov 1, 2018 · 2 comments · Fixed by #14035
Closed

UpSampling Operator Documentation is incomplete #13078

anirudhacharya opened this issue Nov 1, 2018 · 2 comments · Fixed by #14035
Labels
Bug Doc Operator

Comments

@anirudhacharya
Copy link
Member

anirudhacharya commented Nov 1, 2018 •
edited

The UpSampling operator documentation is incomplete - https://mxnet.incubator.apache.org/api/python/ndarray/ndarray.html?highlight=upsam#mxnet.ndarray.UpSampling

It does not show num_args as a parameter - https://github.com/apache/incubator-mxnet/blob/master/src/operator/nn/upsampling-inl.h#L50 . And in bilinear mode the operator expects two inputs - data and weight. Even that is not specified in the documentation.

This can cause confusion like in here - #13073
@anirudhacharya
Copy link
Member Author

@mxnet-label-bot [Operator, Doc, Bug]

@apeforest
Copy link
Contributor

@mxnet-label-bot [Call for Contribution, Good First Issue]

@vandanavk vandanavk mentioned this issue Jan 31, 2019
Merged
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Doc Operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix documentation for bilinear upsampling and add unit test vandanavk/incubator-mxnet
3 participants
@anirudhacharya @apeforest @marcoabreu