Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Engine Issue Tracking #56

Closed
4 tasks done
hotpxl opened this issue Sep 10, 2015 · 5 comments
Closed
4 tasks done

Engine Issue Tracking #56

hotpxl opened this issue Sep 10, 2015 · 5 comments
Assignees
@hotpxl

Comments

@hotpxl
Copy link
Contributor

hotpxl commented Sep 10, 2015

  • Use C style callback
  • Move dispatcher code outside of lock
  • Implement PushAsync for NaiveEngine
  • Isolate out the scheduling part and running policy.
    • The DoPushToQueue logic can be isolated out, as subclass
    • This enables multiple threading policies in for DoPushToQueue
@hotpxl hotpxl self-assigned this Sep 10, 2015
@tqchen
Copy link
Member

tqchen commented Sep 13, 2015

C style callback and PushAsync is done in #63

@tqchen
Copy link
Member

tqchen commented Sep 14, 2015

Dispatcher is moved outside of lock scope in #67

@tqchen
Copy link
Member

tqchen commented Sep 14, 2015

The dispatcher bug is fixed in #69 , now things all out of lock scope.

@tqchen tqchen changed the title Optimizations on engine Optimizations and Concurrency on Engine Sep 20, 2015
@tqchen
Copy link
Member

tqchen commented Sep 20, 2015

It turns out there is another BUG in dispatcher, when things are outside lock scope. The code replied on to_delete_, which could change.

The bugfix is in bd36bbc introduced by #105

@tqchen tqchen changed the title Optimizations and Concurrency on Engine Engine Issue Tracking Sep 26, 2015
@tqchen
Copy link
Member

tqchen commented Oct 11, 2015

Close this for now, will open new issue if new problem emerges

@tqchen tqchen closed this as completed Oct 11, 2015
@firearasi firearasi mentioned this issue Mar 3, 2016
Closed
@lightingghost lightingghost mentioned this issue Jul 9, 2016
Closed
@leleamol leleamol mentioned this issue Dec 8, 2017
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hotpxl hotpxl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hotpxl @tqchen