Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

TEST(MEMORY_TEST, MemsetAndMemcopyPerformance) sometimes failing with timer failures #9649

Closed
KellenSunderland opened this issue Jan 31, 2018 · 3 comments
Labels
C++ Related to C++ Flaky Test

Comments

@KellenSunderland
Copy link
Contributor

Description

Test relies on timings, which may or may not explain why it sometimes fails in CI.

Things to try

We could do a 'near' comparison.

http://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/incubator-mxnet/branches/PR-9609/runs/22/nodes/427/log/?start=0

Environment info (Required)

CI Environment failure.

@marcoabreu marcoabreu added C++ Related to C++ Test Flaky labels Feb 1, 2018
@szha szha added this to To Do in Tests Improvement via automation Feb 1, 2018
@rajanksin
Copy link
Contributor

rajanksin commented Jun 26, 2018

@KellenSunderland @cjolivier01

I am looking at this flaky test, had some queries and comments:

  • The test compares normal memcpy/memset against with using openmp, and expects normal memcpy to be always faster . Although its will be true for small data size ( coz of overhead of creating threads with Openmp), but Openmp will be faster for larger data size , as with multiple threads utilizes greater memory bandwidth.
    Could you please let me know if I am missing something here. (reference to test code )

@KellenSunderland
Copy link
Contributor Author

@spidydev I found this test to vary a lot depending on machine type as well. On my AMD machine it was consistently failing (openmp was always faster) and my intel machine it was consistently passing. I think this would be confusing for users so my recommendation would actually be that we remove this test.

@lupesko
Copy link
Contributor

lupesko commented Jul 2, 2018

@KellenSunderland the PR removing the test was merged. Kindly close the issue. Thanks!

Tests Improvement automation moved this from To Do to Done Jul 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C++ Related to C++ Flaky Test
Projects
Development

No branches or pull requests

4 participants