Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[npl] linux porting layer unit tests fail #785

Closed
turon opened this issue Mar 26, 2020 · 2 comments
Closed

[npl] linux porting layer unit tests fail #785

turon opened this issue Mar 26, 2020 · 2 comments

Comments

@turon
Copy link
Contributor

turon commented Mar 26, 2020

~/mynewt-nimble/porting/npl/linux/test$ make test
./test_npl_task.exe
All tests passed
./test_npl_callout.exe
All tests passed
./test_npl_eventq.exe
All tests passed
./test_npl_sem.exe
make: *** [Makefile:94: test] Segmentation fault

It may be good to add these tests as a github action that gates pull requests.

@turon
Copy link
Contributor Author

turon commented Mar 26, 2020

Looks like this can be fixed by replacing main loop in test_os_sem.c:

BEFORE:

   while (1)
    {
        ble_npl_eventq_run(ble_npl_eventq_dflt_get());
    }

AFTER:

    while (1) {}

@sjanc
Copy link
Contributor

sjanc commented Apr 8, 2020

hmm works for me for both 1.3 and master
[janc@ix test]$ make test
./test_npl_task.exe
All tests passed
./test_npl_callout.exe
All tests passed
./test_npl_eventq.exe
All tests passed
./test_npl_sem.exe
All tests passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants