LSP + VSCode extension: Run/Debug via project actions. #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entlicher
force-pushed
the
F5Consistency
branch
from
a37c7cd
to
63f8da7
Compare
entlicher
requested review from
sdedic and
JaroslavTulach
and removed request for
sdedic
sdedic
reviewed
Dec 6, 2021
| @@ -93,23 +93,18 @@ | |||
|
|
|||
| activeLaunchHandler.preLaunch(launchArguments, context); | |||
|
|
|||
| String filePath = (String)launchArguments.get("mainClass"); | |||
| String filePath = (String)launchArguments.get("file"); | |||
| String mainFilePath = (String)launchArguments.get("mainClass"); | |||
There was a problem hiding this comment.
is the mainClass an URI actually ?
entlicher
changed the title
sdedic
approved these changes
Dec 6, 2021
entlicher
requested review from
JaroslavTulach
and removed request for
sdedic
|
I've unintentionally closed the PR when I wanted to remove an unintentional comment. |
|
I've added the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency reasons we execute project Run/Debug actions instead of file Run/Debug in VSCode. File-sensitive actions are provided as code lenses. Via project's Run/Debug actions users get consistent behavior.
Currently there was
mainClassproperty set to${file}in VSCode'slaunch.json. We are changingmainClassproperty to be optional, it's not set in newly createdlaunch.jsonand we're usingfileproperty set to${file}to get the context.mainClassallows to set a specific file as a context to Run/Debug. When not set, we usefileto determine the current project to run Run/Debug on.We need to adjust Maven projects to be able to Run/Debug without
mainClassset. The project should know it's entry point. Currently, when you create a new Maven project from template, it asks you for the main class before Run/Debug. This is an unexpected behavior for the user, as the newly created project should know its main class. This is why we setexec.mainClassin Maven now.