[NETBEANS-6177] Fix an issue the stop command is not sent #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neilcsmith-net Can we merge this into the |
junichi11
force-pushed
the
netbeans-6177-xdebug
branch
from
0e76d67
to
79f57dd
Compare
tmysik
reviewed
Feb 2, 2022
| @@ -124,6 +125,14 @@ public void run() { | |||
| } catch (Throwable e) { | |||
| log(e, Level.SEVERE); | |||
| } | |||
| if (canceled) { | |||
| synchronized (commands) { | |||
There was a problem hiding this comment.
The change looks good to me. However, the threading in this class is not documented and is not clear to me - I can see no synchronization of commands in preprocess() method, for example.
There was a problem hiding this comment.
tmysik
approved these changes
Feb 2, 2022
|
@neilcsmith-net please merge it if it is OK for you. Thank you, guys! |
|
@tmysik Thank you for your review! |
- https://issues.apache.org/jira/browse/NETBEANS-6177 - Related to NETBEANS-5080 - Use the `canceled` field instead of `detachRequest.set(true)` because the stop command is not sent in `sendStopCommand()` if `detacheRequest` is `true`
junichi11
force-pushed
the
netbeans-6177-xdebug
branch
from
79f57dd
to
582c2c5
Compare
|
OK, thanks, just caught in time for syncing for 13-rc3 so will merge. Not sure if we'll have a 13-rc4 yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canceledfield instead ofdetachRequest.set(true)becausethe stop command is not sent in
sendStopCommand()ifdetacheRequestistrue