LSP Client: Use full complete item to complete, not just the missing suffix #4728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…suffix
This is the test case (typescript):
export class test {
demo() {
this.runstranget|
}
runStrangeThings(): void {
}
}
The codecompletion at the | mark will offer "runStrangeThings", but
completion will yield "this.runstrangethings". The reason is, that
the CC is invoced case-insensitive, so the original string needs to be
replaced with the full result.
matthiasblaesing
added
LSP
|
Hearing no objects, having run with this the last few weeks, travis and github action being happy. I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the test case (typescript):
The codecompletion at the | mark will offer "runStrangeThings", but completion will yield "this.runstrangethings". The reason is, that the CC is invoced case-insensitive, so the original string needs to be replaced with the full result.