Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] clicking on aliased import should navigate to the source #7259

Open
mvorisek opened this issue Apr 11, 2024 · 0 comments
Open

[PHP] clicking on aliased import should navigate to the source #7259

mvorisek opened this issue Apr 11, 2024 · 0 comments
Labels
kind:feature A feature request needs:triage Requires attention from one of the committers PHP [ci] enable extra PHP tests (php/php.editor)

Comments

@mvorisek
Copy link

mvorisek commented Apr 11, 2024

Description

<?php

namespace Data\Mysql;

use Data\Query as BaseQuery;
use Data\Query2;

class Query extends BaseQuery {}

class MyQuery2 extends Query2 {}

Use case/motivation

In the example, the imported Query base class needs to be aliased as it collides with the Query class declaration for MySQL.

When the extends Query2 is clicked by mouse, user is navigated to the source class.

However when the extends BaseQuery is clicked, user is navigated to the import which is unwanted, as the cursor position in the current file changes and an additional click is needed to navigate the source.

I would expect the clicking the extends BaseQuery to navigate to the Data\Query source class directly.

Are you willing to submit a pull request?

No

@mvorisek mvorisek added kind:feature A feature request needs:triage Requires attention from one of the committers labels Apr 11, 2024
@troizet troizet added the PHP [ci] enable extra PHP tests (php/php.editor) label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature A feature request needs:triage Requires attention from one of the committers PHP [ci] enable extra PHP tests (php/php.editor)
Projects
None yet
Development

No branches or pull requests

2 participants