Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stm32_serial: undefined reference to `up_txint' #4353

Closed
lukegluke opened this issue Aug 17, 2021 · 1 comment · Fixed by #4358
Closed

stm32_serial: undefined reference to `up_txint' #4353

lukegluke opened this issue Aug 17, 2021 · 1 comment · Fixed by #4358

Comments

@lukegluke
Copy link
Contributor

lukegluke commented Aug 17, 2021 •
edited

If only TX DMA or RX+TX DMA is used for all uarts the dummy up_dma_txint is used for txint
https://github.com/apache/incubator-nuttx/blob/dc7b9b8dbb1adbb071d75f94cd75a8452eab8f0f/arch/arm/src/stm32/stm32_serial.c#L583

But if CONFIG_STM32_USART_BREAKS and CONFIG_STM32_SERIALBRK_BSDCOMPAT are also set, in TIOCSBRK and TIOCCBRK ioctls undefined up_txint() get called:
https://github.com/apache/incubator-nuttx/blob/dc7b9b8dbb1adbb071d75f94cd75a8452eab8f0f/arch/arm/src/stm32/stm32_serial.c#L2412
https://github.com/apache/incubator-nuttx/blob/dc7b9b8dbb1adbb071d75f94cd75a8452eab8f0f/arch/arm/src/stm32/stm32_serial.c#L2438

that leads to build error
nuttx\arch\arm\src/chip/stm32_serial.c:2412: undefined reference to up_txint
nuttx\arch\arm\src/chip/stm32_serial.c:2438: undefined reference to up_txint
@lukegluke
Copy link
Contributor Author

Looks like bug was introduce in #3222 (3c34337) of yours @raiden00pl.

raiden00pl added a commit to raiden00pl/nuttx that referenced this issue Aug 18, 2021
@raiden00pl
stm32/stm32_serial.c fix compile error when CONFIG_STM32_SERIALBRK_BS…
d99d7f2 
…DCOMPAT=y.

Fix for apache#4353
@raiden00pl raiden00pl mentioned this issue Aug 18, 2021
Merged
@xiaoxiang781216 xiaoxiang781216 linked a pull request Aug 18, 2021 that will close this issue
stm32/stm32_serial.c fix issue #4353 #4358
Merged
xiaoxiang781216 pushed a commit that referenced this issue Aug 18, 2021
@raiden00pl @xiaoxiang781216
stm32/stm32_serial.c fix compile error when CONFIG_STM32_SERIALBRK_BS…
532ec12 
…DCOMPAT=y.

Fix for #4353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stm32/stm32_serial.c fix issue #4353 raiden00pl/nuttx
1 participant
@lukegluke