Skip to content

Commit

Permalink
Improved: The ‘ModelFieldType’ class members should be private.
Browse files Browse the repository at this point in the history
(OFBIZ-10773)

Makes the class members private and remove the default public constructor.

jleroux: All these members are only used in the class and the default public 
constructor is useless (it would be automatically added by the compiler if 
there was no other constructors, and there is one)
http://tutorials.jenkov.com/java/constructors.html#default-no-arg-constructors

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1850728 13f79535-47bb-0310-9956-ffa450edef68
  • Loading branch information
JacquesLeRoux committed Jan 8, 2019
1 parent 08fc69e commit f30cf03
Showing 1 changed file with 5 additions and 12 deletions.
Expand Up @@ -36,22 +36,15 @@ public class ModelFieldType implements Serializable {
public static final String module = ModelFieldType.class.getName();

/** The type of the Field */
protected String type = null;

private String type;
/** The java-type of the Field */
protected String javaType = null;

private String javaType;
/** The JDBC value handler for this Field */
protected JdbcValueHandler<?> jdbcValueHandler = null;

private JdbcValueHandler<?> jdbcValueHandler;
/** The sql-type of the Field */
protected String sqlType = null;

private String sqlType;
/** The sql-type-alias of the Field, this is optional */
protected String sqlTypeAlias = null;

/** Default Constructor */
public ModelFieldType() {}
private String sqlTypeAlias;

/** XML Constructor */
public ModelFieldType(Element fieldTypeElement) {
Expand Down

0 comments on commit f30cf03

Please sign in to comment.