Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Providing Blocking API support for HTTP based services like S3 #2678

Closed
Xuanwo opened this issue Jul 20, 2023 · 6 comments · Fixed by #2780
Closed

feat: Providing Blocking API support for HTTP based services like S3 #2678

Xuanwo opened this issue Jul 20, 2023 · 6 comments · Fixed by #2780

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Jul 20, 2023

OpenDAL doesn't provide blocking API support for services like s3 since they depend on tokio and reqwest. However, mostly of our bindings only have blocking API exported which make its hard to integrate with. We should also provide blocking API support for HTTP based services so our users can use those services.

@jiaoew1991
Copy link
Contributor

The implementation of async and blocking in the hdfs backend are just the same. Can other backends' blocking APIs be exactly the same? 🤔 Or are there other better solutions?

@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 20, 2023

I'm thinking about implement a BlockingLayer which will implement Read and Write by forwarding and waiting the output of async API. I will give it a try first.

@jiaoew1991
Copy link
Contributor

I'm thinking about implement a BlockingLayer which will implement Read and Write by forwarding and waiting the output of async API. I will give it a try first.

Looking forward to this implementation.

@chitralverma
Copy link

@Xuanwo i was just about to draft an issue for this :)
S3, GCS and AZ should ideally have a blocking API and most other languages have support for this as well.

@jiaoew1991
Copy link
Contributor

Hi,May I ask about the progress of this issue? My colleague has a simple implementation that has been successfully debugged locally. Can we try to merge it in?

@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 27, 2023

Hi,May I ask about the progress of this issue? My colleague has a simple implementation that has been successfully debugged locally. Can we try to merge it in?

Wow, I'm willing to review the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants