Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What services should opendal-java bundle? #2732

Closed
tisonkun opened this issue Jul 30, 2023 · 13 comments · Fixed by #2934
Closed

What services should opendal-java bundle? #2732

tisonkun opened this issue Jul 30, 2023 · 13 comments · Fixed by #2934

Comments

@tisonkun
Copy link
Member

Here we have another issue - we don't bundle services-redis for opendal-java. I'll open a new ticket to track it.

Originally posted by @tisonkun in #2730 (comment)

@tisonkun
Copy link
Member Author

@Xuanwo @messense @suyanhanx I'd like to see how other bindings do as well.

@suyanhanx
Copy link
Member

We currently do not specify which services to package, and just use the default. For users, it may also be a way to tell them how to package themselves.🤔

@tisonkun
Copy link
Member Author

@suyanhanx Interesting. Then you may try out the example at https://opendal.apache.org/docs/services/redis for Python and Node.js - I suspect the demo would be just not working.

@tisonkun
Copy link
Member Author

Checked Python -

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
opendal.Error: Unsupported (permanent) at , context: { scheme: redis } => scheme is not enabled or supported

@messense
Copy link
Member

IMO on Python side, we should avoid enabling services that requires additional user setup before/after installing the pre-built wheels such as apt-get install xxx. All other services can be enabled for better UX.

@Xuanwo
Copy link
Member

Xuanwo commented Jul 31, 2023

IMO on Python side, we should avoid enabling services that requires additional user setup before/after installing the pre-built wheels such as apt-get install xxx. All other services can be enabled for better UX.

I'm guessing the only exception is hdfs,

@tisonkun
Copy link
Member Author

I'm thinking of remaining the opendal-java without classifier a platform agnostic version, and all the classifier versions bundled only the opendal shared lib.

@tisonkun
Copy link
Member Author

tisonkun commented Aug 24, 2023

@Xuanwo I'm going to bundle all services except hdfs in opendal-java. Could you share the build options? I'll later test it out.

Currently, I'm using cargo build --color=always --release on opendal-java crate.

@Xuanwo
Copy link
Member

Xuanwo commented Aug 25, 2023

Currently, I'm using cargo build --color=always --release on opendal-java crate.

We need to enable features here for opendal: https://github.com/apache/incubator-opendal/blob/main/bindings/java/Cargo.toml#L35

@tisonkun
Copy link
Member Author

tisonkun commented Aug 25, 2023

@Xuanwo
Copy link
Member

Xuanwo commented Aug 25, 2023

How about all services-* except hdfs?

@suyanhanx
Copy link
Member

How about all services-* except hdfs?

That's it.

@tisonkun
Copy link
Member Author

I'm preparing a patch now. Wondering if we should build and test on different platforms since we release artifacts on different platform. Or we may test the core module on different platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants