Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to make sftp available on windows? #2963

Open
Xuanwo opened this issue Aug 29, 2023 · 12 comments
Open

Is it possible to make sftp available on windows? #2963

Xuanwo opened this issue Aug 29, 2023 · 12 comments

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Aug 29, 2023

Hi, sftp is marked as unix only. But windows seems have sftp support too. I want to know is it possible to make sftp available on windows and macos?

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 29, 2023

cc @silver-ymz and @NobodyXu for comments.

@silver-ymz
Copy link
Member

silver-ymz commented Aug 29, 2023

It seems be blocked by openssh-rust/openssh-mux-client#6

And openssh-rust windows support has been tracked in https://github.com/openssh-rust/openssh/milestone/2

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 29, 2023

Thanks a lot for the information!

@NobodyXu
Copy link
Contributor

@silver-ymz is right, it's blocked on that issue and I don't have much time to work on it recently.

Would probably have to re-consider how to implement it, probably reducing scope and simplify the impl (I added a bunch custom sync primitives that are more performant but just wasting effort) and start implementing it.

@NobodyXu
Copy link
Contributor

I would welcome any PR on that and willing to spend my time reviewing them quickly after PR opens/updates and answering questions for as long as it takes

I'm currently busy with my $DAYJOB and other open source projects, so it would take a long time until I get to do it myself.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 29, 2023

I'm currently busy with my $DAYJOB and other open source projects, so it would take a long time until I get to do it myself.

Thanks a lot for your contribution!

I initiated this inquiry to gather information about the context, and now that I am aware of its feasibility, it has unfortunately been blocked. We will proceed with this task once we receive sufficient user requests for this feature. Therefore, there is no need to rush.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 29, 2023

cc @silver-ymz, would you like to start a PR to update the comments about sftp services that unix only? This will allow users who are interested in this feature to leave their comments here and contribute to its development. I think we can link to this issue directly.

@silver-ymz
Copy link
Member

I'd like to do it.
And we can also update the comments about password login support. We can link it to openssh-rust/openssh#119. I think this is also a feature that users expect.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 29, 2023

We can link it to openssh-rust/openssh#119. I think this is also a feature that users expect.

I prefer to start an issue at OpenDAL, link to openssh-rust in the issue. And our docs should only link to OpenDAL's issue.

@silver-ymz
Copy link
Member

I have opened an issue #2966 to track password login support.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 29, 2023

Hi, I would like to suggest removing the blocked by upstream label. It seems more like pressure on the upstream instead of being helpful.

Let me clarify the following points:

  • No users have requested this feature.
  • The upstream is willing to accept this contribution but it has been postponed due to lack of time.
  • We proposed the feature request ourselves and it should not burden the upstream.
  • We are not blocked and there is no need for us to add this label.

@aawsome
Copy link

aawsome commented Jan 18, 2024

As we use opendal in rustic (thank you very much for your great project!!), I wanted to mention that we would like to request this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants