Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CallbackReader to calculate the read cost #84

Closed
Tracked by #65
Xuanwo opened this issue Mar 1, 2022 · 0 comments · Fixed by #92
Closed
Tracked by #65

Allow CallbackReader to calculate the read cost #84

Xuanwo opened this issue Mar 1, 2022 · 0 comments · Fixed by #92
Assignees
@Xuanwo

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Mar 1, 2022

Ok, I got the problem. The callback was triggered at the end of this read, so we cannot calculate the cost of every read operation. Let me find a solution for it.

Originally posted by @Xuanwo in datafuselabs/databend#4256 (comment)
This was referenced Mar 1, 2022
Closed
Merged
@Xuanwo Xuanwo linked a pull request Mar 2, 2022 that will close this issue
readers: Implement observe reader support #92
Merged
@Xuanwo Xuanwo self-assigned this Mar 2, 2022
@Xuanwo Xuanwo closed this as completed in #92 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xuanwo Xuanwo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

readers: Implement observe reader support Xuanwo/opendal
1 participant
@Xuanwo