Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1358 - Failing tests on Windows 11 and Java 17 #476

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Dec 30, 2022

What does this PR do?

Tests are not failing on Windows anymore. This PR adds build support for Windows (latest = Server 2022) and adjusts test cases (if needed) to be run on GH actions CI.

Matrix build is now happy: https://github.com/rzo1/opennlp/actions/runs/3809019320

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.github/workflows/maven.yml Show resolved Hide resolved
@rzo1 rzo1 force-pushed the OPENNLP-1358_Failing_tests_on_Windows_11_and_Java_1 branch from 339c641 to 97409dd Compare December 31, 2022 08:41
@rzo1 rzo1 force-pushed the OPENNLP-1358_Failing_tests_on_Windows_11_and_Java_1 branch from 97409dd to fe7945e Compare December 31, 2022 08:46
@jzonthemtn jzonthemtn merged commit 04028e9 into apache:main Jan 1, 2023
@rzo1 rzo1 deleted the OPENNLP-1358_Failing_tests_on_Windows_11_and_Java_1 branch January 2, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants