OPENNLP-1358 - Failing tests on Windows 11 and Java 17 #476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tests are not failing on Windows anymore. This PR adds build support for Windows (latest = Server 2022) and adjusts test cases (if needed) to be run on GH actions CI.
.gitattributes
as we have a checkstyle rule in place which prohibits the use of CRLF (checkstyle will fail a build on Windows ifgit
isn't configured accordingly).gitattributes
, see https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings) viagit add --renormalize .
@TempDir
created folders cannot be deleted on Windows Server 2022)Matrix build is now happy: https://github.com/rzo1/opennlp/actions/runs/3809019320
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.