Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use own copy of actionProxy.py use common one from dockerskeleton #15

Closed
csantanapr opened this issue Feb 3, 2018 · 2 comments
Closed
Assignees

Comments

@csantanapr
Copy link
Member

csantanapr commented Feb 3, 2018

We currently have our own copy of actionProxy/actionproxy.py
https://github.com/apache/incubator-openwhisk-runtime-swift/blob/master/core/actionProxy/actionproxy.py#L186

We should instead use the one from dockerSkeleton, but for swift4 we need to update dockerSkeleton to take a fourth parameter zipdest to be able to override the destination of the zip when unzipping the action.

This snippet needs to be push upstream to runtime docker and then pull down from Dockerfile

    def __init__(self, source=None, binary=None, zipdest=None):
        defaultBinary = '/action/exec'
        self.source = source if source else defaultBinary
        self.binary = binary if binary else defaultBinary
        self.zipdest = zipdest if zipdest else os.path.dirname(self.source)

Once that's availabl we can update Dockerfile with

# Add the action proxy
RUN mkdir -p /actionProxy
ADD https://raw.githubusercontent.com/apache/incubator-openwhisk-runtime-docker/dockerskeleton%401.0.0/core/actionProxy/actionproxy.py /actionProxy/actionproxy.py
@csantanapr
Copy link
Member Author

Depends on apache/openwhisk-runtime-docker#13

@csantanapr
Copy link
Member Author

Closed by #13

@csantanapr csantanapr self-assigned this Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant