Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application-json no longer considered "binary" after migration from spray to akka #2606

Closed
rabbah opened this issue Aug 12, 2017 · 2 comments

Comments

@rabbah
Copy link
Member

rabbah commented Aug 12, 2017

so we can support json without base64 encoding/decoding for http web actions.
this will make a lot of users happy.

we'll support both modes for a while and then drop the requirement since it's just too common a case.

@rabbah
Copy link
Member Author

rabbah commented Aug 12, 2017

To clarify the port preserved the existing behavior. We will have to change the web action handler to eschew the decoding and hence support both new and old formats.

@rabbah
Copy link
Member Author

rabbah commented Aug 12, 2017

The proposed patch in #2609 allows an HTTP web action to respond with a JSON value without having to base64 encode it. As in

function main(args) { return { statusCode: 201, body: args } }

Supplying an already decoded JSON value as an argument however where it is otherwise base64 encoded today requires some care - perhaps we need a compatibility mode option. Note that this applies only for raw HTTP actions which are not the common cases. So maybe we do nothing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant