Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golang runtime support to default deployments #4085

Closed
csantanapr opened this issue Oct 26, 2018 · 12 comments
Closed

Add golang runtime support to default deployments #4085

csantanapr opened this issue Oct 26, 2018 · 12 comments
Labels

Comments

@csantanapr
Copy link
Member

csantanapr commented Oct 26, 2018

Title: Add golang runtime support to default deployments

1. Add golang to core ansible/vagrant deploy

"golang": [
    {
        "kind": "golang:1.11",
        "default": true,
        "deprecated": false,
        "attached": {
            "attachmentName": "codefile",
            "attachmentType": "text/plain"
        },
        "image": {
            "prefix": "openwhisk",
            "name": "actionloop-golang-v1.11",
            "tag": "latest"
        }
    }
]

Use Ruby PR as reference: #3725

2. Add golang to CLI

3. Add golang to docker-compose deploy

4. Add golang to deploy-kube

5. Update wskdeploy

Issue opened here apache/openwhisk-wskdeploy#1004

6 Update website

Issue opened here apache/openwhisk-website#343

@csantanapr
Copy link
Member Author

cc @sciabarra ^^

@rabbah rabbah self-assigned this Oct 26, 2018
@rabbah
Copy link
Member

rabbah commented Oct 26, 2018

Excellent. Glad to see this!

@rabbah rabbah removed their assignment Oct 26, 2018
@rabbah rabbah added the runtime label Oct 26, 2018
@csantanapr
Copy link
Member Author

I think folks voted in mailing list for --king go:1.11 over --kind golang:1.11
So it needs to be

"go": [
    {
        "kind": "go:1.11",
        "default": true,
        "deprecated": false,
        "attached": {
            "attachmentName": "codefile",
            "attachmentType": "text/plain"
        },
        "image": {
            "prefix": "openwhisk",
            "name": "actionloop-golang-v1.11",
            "tag": "latest"
        }
    }
]

@sciabarracom
Copy link
Contributor

Submitted all the 4 PR required.

@csantanapr
Copy link
Member Author

core repo PR merged: #4093

@csantanapr
Copy link
Member Author

deploy-kube repo merged: apache/openwhisk-deploy-kube#327

@csantanapr
Copy link
Member Author

@daisy-ycguo Do you know if we need changes for wskdeploy?

@csantanapr
Copy link
Member Author

The devtools PR is merged: apache/openwhisk-devtools#172

@csantanapr
Copy link
Member Author

core cli PR is merged now: apache/openwhisk-cli#375

@csantanapr
Copy link
Member Author

I need to check if wskdeploy needs to updated with the runtime

@csantanapr
Copy link
Member Author

@sciabarracom You want to handle these also

I added items 5 and 6 above

5. Update wskdeploy

Issue opened here apache/openwhisk-wskdeploy#1004

6 Update website

Issue opened here apache/openwhisk-website#343

@csantanapr
Copy link
Member Author

All issues are closed now 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants