PARQUET-1629: Support CRC for data page v2 #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
changed the title
|
Just curious, are there real use cases for page V2? |
IMO, it has some advantages such as turning on/off compression per page. |
wgtmac
changed the title
|
cc @mapleFU as you have implemented this in the parquet-cpp. |
|
LGTM |
shangxinli
approved these changes
Jul 23, 2023
mapleFU
reviewed
Jul 23, 2023
| final BytesInput definitionLevels = this.readAsBytesInput(dataHeaderV2.getDefinition_levels_byte_length()); | ||
| final BytesInput values = this.readAsBytesInput(dataSize); | ||
| if (options.usePageChecksumVerification() && pageHeader.isSetCrc()) { | ||
| pageBytes = BytesInput.concat(repetitionLevels, definitionLevels, values); |
There was a problem hiding this comment.
Does this concat three parts and get crc? Can it accumulated crc and avoid concat these buffers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://issues.apache.org/jira/browse/PARQUET-1629
Tests
Refactored
TestDataPageV1Checksumsto support both V1 and V2 data pages in all cases.Commits